fix(server): http error parsing on endpoints without a default response #12927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
commented
Sep 25, 2024
Comment on lines
+3494
to
+3500
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "$ref": "#/components/schemas/TestEmailResponseDto" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Previously no default response type.
jrasm91
commented
Sep 25, 2024
| @@ -2220,7 +2223,10 @@ export function addMemoryAssets({ id, bulkIdsDto }: { | |||
| export function sendTestEmail({ systemConfigSmtpDto }: { | |||
| systemConfigSmtpDto: SystemConfigSmtpDto; | |||
| }, opts?: Oazapfts.RequestOpts) { | |||
| return oazapfts.ok(oazapfts.fetchText("/notifications/test-email", oazapfts.json({ | |||
There was a problem hiding this comment.
Changed from fetchText to fetchJson
zackpollard
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10166
You can see in the open api spec, that this endpoint did not have a default resopnse, so open-api assumed it was a string and did not parse the response. This is why
handleErrorwas unable to extract the message correctly.This PR fixes that parsing, but also adds a default response for this endpoint (returns
messageId).