fix: normalize external domain #12831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
force-pushed
the
chore/normalize-external-domain
branch
2 times, most recently
from
1b5fc37 to
9ec1bf1
Compare
jrasm91
approved these changes
Sep 21, 2024
danieldietzler
changed the title
danieldietzler
force-pushed
the
chore/normalize-external-domain
branch
from
9ec1bf1 to
fbfa81f
Compare
jrasm91
force-pushed
the
chore/normalize-external-domain
branch
from
fbfa81f to
a445aab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9564. In there, @jrasm91 proposed to normalize the domain when returning it, so I did that. Wondering if it makes more sense to normalize it when stored to the DB though...?