Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): hide tree view text overflow with ellipsis #12161

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix(web): hide tree view text overflow with ellipsis #12161

merged 1 commit into from
Aug 30, 2024

Conversation

ben-basten
Copy link
Member

@ben-basten ben-basten commented Aug 30, 2024 •
edited
Loading

Description

Truncate text in the tree with an ellipsis if the name is too long. This is similar to the behavior in GitHub for pull request diffs.

How Has This Been Tested?

  1. Create a couple of nested, long tag names. For example: supercalifragilisticexpialidocious/supercalifragilisticexpialidocious/supercalifragilisticexpialidocious
  2. Verify that the sidebar never overflows or allows horizontal scrolling

Screenshots

Expand for screenshot

sidebar-ellipsis

@ben-basten ben-basten changed the title fix(web): hide tree view overflow with ellipsis fix(web): hide tree view text overflow with ellipsis Aug 30, 2024
@ben-basten ben-basten marked this pull request as ready for review August 30, 2024 20:12
@jrasm91 jrasm91 merged commit 4cc11ef into main Aug 30, 2024
25 of 26 checks passed
@jrasm91 jrasm91 deleted the fix/tree-overflow branch August 30, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
changelog:bugfix 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-basten @jrasm91