fix(server): video duration extraction #11610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
approved these changes
Aug 6, 2024
| } else if (typeof seconds === 'string') { | ||
| _seconds = Duration.fromISOTime(seconds).as('seconds'); | ||
| if (videoStreams[0]) { | ||
| switch (videoStreams[0].rotation) { |
There was a problem hiding this comment.
Not blocking since this is existing code, but only checking the first stream isn't reliable. The media service uses the stream with the highest frame count, which may or may not be the first stream.
alextran1502
approved these changes
Aug 6, 2024
|
How do I apply this to existing videos? |
jrasm91
approved these changes
Aug 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting the video duration based on EXIF data has proven to be unreliable. Exiftool has 7 different ways for calculating the
Durationvalue, and if any of those are missing or invalid the duration will also be wrong. Usingffprobeis a more reliable solution to determine the video duration.Using an MKV test file the duration is now correctly extracted as
00:01:27.336, whereas it was previously24:15:36.000. This should fix #7312 and fix #8244, though I can't verify that myself