Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): more localized number formatting #11401

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat(web): more localized number formatting #11401

merged 1 commit into from
Jul 29, 2024

Conversation

michelheusschen
Copy link
Contributor

Note that number.toLocaleString($locale, { style: 'percent' }) automatically multiplies the number by 100

danieldietzler
danieldietzler approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jrasm91 jrasm91 merged commit 0237f9b into main Jul 29, 2024
22 checks passed
@jrasm91 jrasm91 deleted the feat/web-localized-number-formatting branch July 29, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michelheusschen @jrasm91 @danieldietzler