fix(server): correct person birth date across timezones #11369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelheusschen
commented
Jul 26, 2024
| @@ -185,13 +194,13 @@ describe('/people', () => { | |||
| .set('Authorization', `Bearer ${admin.accessToken}`) | |||
| .send({ | |||
| name: 'New Person', | |||
| birthDate: '1990-01-01T05:00:00.000Z', | |||
| birthDate: '1990-01-01', | |||
There was a problem hiding this comment.
Not sure if dates with a time should be accepted. I've removed the time part for now.
jrasm91
reviewed
Jul 26, 2024
jrasm91
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The person's birth date is being set to the previous day when the server has a timezone with a negative UTC offset. Fixes #11354 by keeping
birthDateas a string instead of converting it to aDate.Testing this is difficult, because there doesn't seem to be a way to set the timezone during tests.