Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): user can remove server license #11199

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(web): user can remove server license #11199

merged 1 commit into from
Jul 18, 2024

Conversation

alextran1502
Copy link
Contributor

Fixes #11195

@alextran1502 alextran1502 merged commit e005a12 into main Jul 18, 2024
22 checks passed
@alextran1502 alextran1502 deleted the fix-11195 branch July 18, 2024 19:26
leepfrog-ger
leepfrog-ger reviewed Jul 18, 2024
View reviewed changes
Copy link

@leepfrog-ger leepfrog-ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t that just hide the button in the UI? From my understanding a user directly calling the correct API/endpoint would still be able to remove the license if it is not checked server side.

@jrasm91
Copy link
Contributor

jrasm91 commented Jul 18, 2024

Only the admin can call that endpoint (server-side check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leepfrog-ger leepfrog-ger leepfrog-ger left review comments

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users have button to remove license
4 participants
@alextran1502 @jrasm91 @leepfrog-ger @danieldietzler