-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): license UI #11182
feat(web): license UI #11182
Conversation
web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on the side bar design, I really like it!
<div class="hidden md:block license-status pl-4 text-sm"> | ||
{#if $isLicenseActivated} | ||
<button | ||
on:click={() => goto(`${AppRoute.USER_SETTINGS}?isOpen=user-license-settings`)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just be a regular link
<button | ||
type="button" | ||
on:click={openLicenseModal} | ||
on:mouseenter={() => (showMessage = true)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message that stays visible after I hovered over this is pretty annoying
<Portal target="body"> | ||
{#if showMessage && getAccountAge() > 14} | ||
<div | ||
class="w-[265px] absolute bottom-[75px] left-[255px] bg-white dark:bg-gray-800 dark:text-white text-black rounded-xl z-10 shadow-2xl px-4 py-5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The position of this message will be wrong when not using 100% zoom
I really hope this will not get annoying for unlicensed users. It would probably end in a fork of Immich with all of this removed. Calling it a „trial“ when no license is activated gives me WinRAR vibes. |
@LucaDev the only difference is just that status text to show licensed vs unlicensed |
I guess that will be fine. Don’t get me wrong - I think you should absolutely be able to earn some money for all of this. |
@LucaDev For sure, we are not planning on that 😄 |
The wording choice is a bit suspicious to me. Seeing as this is AGPL licenced and distributed freely, what does it mean when it says unpaid use is "unlicensed" as in "not permitted"? Even though the actual legal text of the license says I have the right to do more than use it for any number of users. Does this imply that the licence will be switched in the future to something that contains further restrictions on the use and/or modification of Immich? If not, why not say something like "unpaid" instead then? To be clear, I have nothing against you making money with this, you fully deserve it. I love Immich so far, and would gladly pay you $25. I just fear it'll turn into some "source available" not-actually-free (as in freedom) software, and I'll have to migrate to something else (out of principle if nothing else). |
No description provided.