Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Rename the Menu Entry "admin.map_settings" to "admin.map_gps_settings" #11033

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

MickLesk
Copy link
Contributor

@MickLesk MickLesk commented Jul 11, 2024

Explanation:
The main menu item is called Map & GPS-Settings. The sub-item below it is also called. It would be correct:

Main item:
Map & GPS-Settings
Sub-item 1:
Map settings

image

Should be:
image

Change in Weblate is required (the "& GPS" need to be removed from "admin.map_settings" and "admin.map_description")
New Keys:
- admin.map_gps_settings
- admin.map_gps_description

Edit: done by me, thx @michelheusschen for input

Final Result:
image

Explanation:
The main menu item is called Map & GPS-Settings. The sub-item below it is also called. 
It would be correct:

Main item:
Map & GPS-Settings
Sub-item 1:
Map settings
@MickLesk MickLesk changed the title Rename the Menu Entry "admin.map_settings" to "admin.map_gps_settings" feat(web): Rename the Menu Entry "admin.map_settings" to "admin.map_gps_settings" Jul 11, 2024
@michelheusschen
Copy link
Contributor

You can make the necessary changes in en.json and Weblate will automatically pick them up once merged

@MickLesk
Copy link
Contributor Author

You can make the necessary changes in en.json and Weblate will automatically pick them up once merged

ah perfect! That's exactly what I was looking for, I wasn't looking for it in that place. Done :-) Now I know what to do next time.

@jrasm91 jrasm91 enabled auto-merge (squash) July 11, 2024 15:15
@jrasm91 jrasm91 merged commit ff2ba24 into immich-app:main Jul 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants