feat(web): use browser language by default #10849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #10720. Works for |
|
It's still there for me
|
danieldietzler
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default language is set using the first match in
navigator.languages, with english as fallback. Handling languages likear-AEwhich should use the less specificar, adds some complexity. Althoughsvelte-i18nalready uses the less specific language internally, it's not exposed so we can't use it. This means some extra logic is needed to determine which language is selected by default.Less specific languages such as
zhare ignored, because you can't safely choose between zh-Hans or zh-Hant.