Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): live photo relation #10637

Merged
merged 6 commits into from
Jun 27, 2024
Merged

fix(server): live photo relation #10637

merged 6 commits into from
Jun 27, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jun 26, 2024 •
edited by alextran1502
Loading

  • Change live photo relation from one to one to one to many
  • This allows multiple photos to be linked to the same video

TODO:

  • e2e tests for this scenario (multiple photos to same video)
  • fix logic around deleting motion videos, which can now be linked to multiple photo assets

@alextran1502 alextran1502 self-assigned this Jun 27, 2024
@alextran1502 alextran1502 marked this pull request as ready for review June 27, 2024 17:37
@alextran1502 alextran1502 linked an issue Jun 27, 2024 that may be closed by this pull request
Ghost files #10596
Closed
3 tasks
@alextran1502 alextran1502 merged commit 7e99394 into main Jun 27, 2024
24 checks passed
@alextran1502 alextran1502 deleted the fix/live-photo-relation branch June 27, 2024 19:41
@alextran1502 alextran1502 mentioned this pull request Jun 27, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@danieldietzler danieldietzler Awaiting requested review from danieldietzler danieldietzler is a code owner

Assignees

@alextran1502 alextran1502

Labels
🗄️server
Projects
Alex's list
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ghost files
2 participants
@jrasm91 @alextran1502