-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server) Tagging system #1046
Changes from 26 commits
bc79a71
a2cdb81
b12ecd0
228aed5
41f26ef
790247f
c0ddef1
f0aa2a2
6d9e47d
d65d12a
23e4d5d
6d65335
af14e6a
d9c2d92
6219077
6bf2608
8ef8cab
d379f63
609c9ab
faf43bf
0b7a91c
297faef
3b03be9
893d6b9
dc0c2e5
0081a66
ce6410a
23342eb
5e87912
19544c6
c9804d3
8c164d9
26cf312
3cb1a06
cd68a17
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
mobile/openapi/**/*.md -diff -merge | ||
mobile/openapi/**/*.md linguist-generated=true | ||
mobile/openapi/**/*.dart -diff -merge | ||
mobile/openapi/**/*.dart linguist-generated=true | ||
|
||
web/src/api/open-api/**/*.md -diff -merge | ||
web/src/api/open-api/**/*.md linguist-generated=true | ||
|
||
web/src/api/open-api/**/*.ts -diff -merge | ||
web/src/api/open-api/**/*.ts linguist-generated=true | ||
|
||
mobile/openapi/.openapi-generator/FILES -diff -merge | ||
mobile/openapi/.openapi-generator/FILES linguist-generated=true |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,3 +27,6 @@ prod-scale: | |
|
||
api: | ||
cd ./server && npm run api:generate | ||
|
||
attach-server: | ||
docker exec -it docker_immich-server_1 sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,31 @@ | ||
# TODO | ||
# Tagging system | ||
|
||
Server scenario with web | ||
This feature implements a tagging system for Immich. The goal is to achieve the following features: | ||
|
||
[ ] 1 user exist without admin right -> make admin on first check | ||
- Users can create tags | ||
- Users can delete tags | ||
- Users can edit tags | ||
- Users can view tags | ||
- Users can add tags to an asset | ||
- Users can remove tags from an asset | ||
- Albums can be created from tags | ||
- Search can be performed on tags | ||
|
||
[ ] 2 users exist without admin right -> ask user to choose which account will be the admin | ||
## Implementation | ||
|
||
- Tags are stored in a separate table. | ||
- Tags type are defined as an enum (i.e Objects, Faces, Custom (User Defined)...etc). | ||
- Migrate the current `smart_info` album to the tags table - How to do this undisruptively? - add then delete entry? | ||
- Search interface for tags | ||
- tags are displayed in search suggestion | ||
- tags can be search as text similar to exif table | ||
- Tags are displayed in the asset view | ||
- Smart album creation from tags? | ||
- Tags can only be added by the owner | ||
|
||
## Tag types (extensible) | ||
|
||
- Objects (system generated) | ||
- Faces (system generated) | ||
- Custom (user defined) | ||
|
||
[ X ] No users exist -> prompt signup form for Admin |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file need to be committed? Are we going to start documenting "notes" here? Should we maybe just add something like this to the documentation site instead?