Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): use preview image when generating person thumbnail from video #10240

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mertalev
Copy link
Contributor

Description

Following #7513, person thumbnails now crop from the original asset for higher quality thumbnails. However, videos can't easily use this approach and should instead continue to use the preview image.

How Has This Been Tested?

Tested by changing a feature photo to a video and confirming that it generated successfully. It failed on main.

@mertalev mertalev merged commit fb641c7 into main Jun 13, 2024
22 checks passed
@mertalev mertalev deleted the fix/server-use-preview-for-video-person-thumbnails branch June 13, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants