refactor: add option to store configuration in a secret#296
Merged
Conversation
Member
|
Perhaps it should just be called |
…is either Secret or ConfigMap
YotamKorah
force-pushed
the
refactor/config-as-secret
branch
from
18f794d to
c8c733c
Compare
Contributor
Author
|
OK I updated as you suggested and added a check to verify that configurationKind is valid |
bo0tzz
approved these changes
Dec 2, 2025
Contributor
Author
|
Sorry, clicked request review by mistake |
Contributor
Author
|
Hi, any chance we could merge this PR please? |
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Mar 28, 2026
##### [\`0.11.0\`](https://github.com/immich-app/immich-charts/releases/tag/immich-0.11.0) A chart to power Immich (immich.app) running on kubernetes #### What's Changed - chore(deps): update dependency tilt to v0.36.0 by [@renovate](https://github.com/renovate)\[bot] in [#294](immich-app/immich-charts#294) - chore: group helm updates by [@bo0tzz](https://github.com/bo0tzz) in [#298](immich-app/immich-charts#298) - chore(deps): update dependency kubectl to v1.34.2 by [@renovate](https://github.com/renovate)\[bot] in [#293](immich-app/immich-charts#293) - chore(deps): update github-actions by [@renovate](https://github.com/renovate)\[bot] in [#288](immich-app/immich-charts#288) - chore(deps): update helm release common to v4.5.0 by [@renovate](https://github.com/renovate)\[bot] in [#305](immich-app/immich-charts#305) - chore(deps): update docker.io/valkey/valkey:9.0-alpine docker digest to [`1be4944`](immich-app/immich-charts@1be4944) by [@renovate](https://github.com/renovate)\[bot] in [#300](immich-app/immich-charts#300) - refactor: add option to store configuration in a secret by [@YotamKorah](https://github.com/YotamKorah) in [#296](immich-app/immich-charts#296) - chore(deps): update dependency kubectl to v1.34.3 by [@renovate](https://github.com/renovate)\[bot] in [#304](immich-app/immich-charts#304) - chore(deps): update actions/create-github-app-token action to v2.2.1 - autoclosed by [@renovate](https://github.com/renovate)\[bot] in [#303](immich-app/immich-charts#303) - chore(deps): update helm to v4 (major) by [@renovate](https://github.com/renovate)\[bot] in [#302](immich-app/immich-charts#302) - chore(deps): update github-actions by [@renovate](https://github.com/renovate)\[bot] in [#315](immich-app/immich-charts#315) - chore(deps): update docker.io/valkey/valkey docker tag to v9.1 by [@renovate](https://github.com/renovate)\[bot] in [#325](immich-app/immich-charts#325) - chore(deps): update int128/diff-action to v2 (major) by [@bo0tzz](https://github.com/bo0tzz) in [#329](immich-app/immich-charts#329) - chore: deprecate http repo by [@bo0tzz](https://github.com/bo0tzz) in [#326](immich-app/immich-charts#326) - fix(service): Add service appProtocol websocket to allow health and version check by [@jjpebesma](https://github.com/jjpebesma) in [#323](immich-app/immich-charts#323) - chore(deps): update helm to v4.1.3 by [@renovate](https://github.com/renovate)\[bot] in [#301](immich-app/immich-charts#301) - chore(deps): update dependency kubectl to v1.35.3 by [@renovate](https://github.com/renovate)\[bot] in [#311](immich-app/immich-charts#311) - feat(config): add option to use an existing config not managed by the chart by [@YotamKorah](https://github.com/YotamKorah) in [#307](immich-app/immich-charts#307) - chore(deps): update helm release common to v4.6.2 by [@renovate](https://github.com/renovate)\[bot] in [#316](immich-app/immich-charts#316) - chore(deps): update github-actions (major) by [@renovate](https://github.com/renovate)\[bot] in [#297](immich-app/immich-charts#297) - chore(deps): update dependency kind to v0.31.0 by [@renovate](https://github.com/renovate)\[bot] in [#310](immich-app/immich-charts#310) - chore(deps): update dependency tilt to v0.37.0 by [@renovate](https://github.com/renovate)\[bot] in [#320](immich-app/immich-charts#320) - chore(deps): update github-actions by [@renovate](https://github.com/renovate)\[bot] in [#324](immich-app/immich-charts#324) - chore(deps): bump Immich version to v2.6.3 by [@bo0tzz](https://github.com/bo0tzz) in [#327](immich-app/immich-charts#327) - chore: release 0.11.0 by [@bo0tzz](https://github.com/bo0tzz) in [#328](immich-app/immich-charts#328) #### New Contributors - [@YotamKorah](https://github.com/YotamKorah) made their first contribution in [#296](immich-app/immich-charts#296) - [@jjpebesma](https://github.com/jjpebesma) made their first contribution in [#323](immich-app/immich-charts#323) **Full Changelog**: <immich-app/immich-charts@immich-0.10.3...immich-0.11.0>
sdwilsh
pushed a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Mar 28, 2026
##### [\`0.11.0\`](https://github.com/immich-app/immich-charts/releases/tag/immich-0.11.0) A chart to power Immich (immich.app) running on kubernetes #### What's Changed - chore(deps): update dependency tilt to v0.36.0 by [@renovate](https://github.com/renovate)\[bot] in [#294](immich-app/immich-charts#294) - chore: group helm updates by [@bo0tzz](https://github.com/bo0tzz) in [#298](immich-app/immich-charts#298) - chore(deps): update dependency kubectl to v1.34.2 by [@renovate](https://github.com/renovate)\[bot] in [#293](immich-app/immich-charts#293) - chore(deps): update github-actions by [@renovate](https://github.com/renovate)\[bot] in [#288](immich-app/immich-charts#288) - chore(deps): update helm release common to v4.5.0 by [@renovate](https://github.com/renovate)\[bot] in [#305](immich-app/immich-charts#305) - chore(deps): update docker.io/valkey/valkey:9.0-alpine docker digest to [`1be4944`](immich-app/immich-charts@1be4944) by [@renovate](https://github.com/renovate)\[bot] in [#300](immich-app/immich-charts#300) - refactor: add option to store configuration in a secret by [@YotamKorah](https://github.com/YotamKorah) in [#296](immich-app/immich-charts#296) - chore(deps): update dependency kubectl to v1.34.3 by [@renovate](https://github.com/renovate)\[bot] in [#304](immich-app/immich-charts#304) - chore(deps): update actions/create-github-app-token action to v2.2.1 - autoclosed by [@renovate](https://github.com/renovate)\[bot] in [#303](immich-app/immich-charts#303) - chore(deps): update helm to v4 (major) by [@renovate](https://github.com/renovate)\[bot] in [#302](immich-app/immich-charts#302) - chore(deps): update github-actions by [@renovate](https://github.com/renovate)\[bot] in [#315](immich-app/immich-charts#315) - chore(deps): update docker.io/valkey/valkey docker tag to v9.1 by [@renovate](https://github.com/renovate)\[bot] in [#325](immich-app/immich-charts#325) - chore(deps): update int128/diff-action to v2 (major) by [@bo0tzz](https://github.com/bo0tzz) in [#329](immich-app/immich-charts#329) - chore: deprecate http repo by [@bo0tzz](https://github.com/bo0tzz) in [#326](immich-app/immich-charts#326) - fix(service): Add service appProtocol websocket to allow health and version check by [@jjpebesma](https://github.com/jjpebesma) in [#323](immich-app/immich-charts#323) - chore(deps): update helm to v4.1.3 by [@renovate](https://github.com/renovate)\[bot] in [#301](immich-app/immich-charts#301) - chore(deps): update dependency kubectl to v1.35.3 by [@renovate](https://github.com/renovate)\[bot] in [#311](immich-app/immich-charts#311) - feat(config): add option to use an existing config not managed by the chart by [@YotamKorah](https://github.com/YotamKorah) in [#307](immich-app/immich-charts#307) - chore(deps): update helm release common to v4.6.2 by [@renovate](https://github.com/renovate)\[bot] in [#316](immich-app/immich-charts#316) - chore(deps): update github-actions (major) by [@renovate](https://github.com/renovate)\[bot] in [#297](immich-app/immich-charts#297) - chore(deps): update dependency kind to v0.31.0 by [@renovate](https://github.com/renovate)\[bot] in [#310](immich-app/immich-charts#310) - chore(deps): update dependency tilt to v0.37.0 by [@renovate](https://github.com/renovate)\[bot] in [#320](immich-app/immich-charts#320) - chore(deps): update github-actions by [@renovate](https://github.com/renovate)\[bot] in [#324](immich-app/immich-charts#324) - chore(deps): bump Immich version to v2.6.3 by [@bo0tzz](https://github.com/bo0tzz) in [#327](immich-app/immich-charts#327) - chore: release 0.11.0 by [@bo0tzz](https://github.com/bo0tzz) in [#328](immich-app/immich-charts#328) #### New Contributors - [@YotamKorah](https://github.com/YotamKorah) made their first contribution in [#296](immich-app/immich-charts#296) - [@jjpebesma](https://github.com/jjpebesma) made their first contribution in [#323](immich-app/immich-charts#323) **Full Changelog**: <immich-app/immich-charts@immich-0.10.3...immich-0.11.0>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I love this project and have been using it a lot. I wanted to contribute a bit and thought this small commit is a good place to start.
This pull request adds support for optionally storing the Immich configuration in a Kubernetes Secret instead of a ConfigMap, improving security for sensitive configurations. The change is controlled by a new
storeConfigInSecretvalue. The chart version has also been bumped to reflect this enhancement.Support for storing configuration in a Secret:
immich-config.ymlto create either a Secret or ConfigMap based on theimmich.storeConfigInSecretvalue, including handling oftypeand data fields accordingly. [1] [2]server.yamlto mount the configuration as either a secret or configMap, depending on the same value.storeConfigInSecretoption invalues.yamlwith a default offalseand documentation.Chart version update:
0.10.3to0.10.4inChart.yamlto reflect the new feature.