Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device filtering. #725

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix device filtering. #725

merged 2 commits into from
Sep 1, 2023

Conversation

bitbound
Copy link
Contributor

Filtering/sorting was taking an extra render to show. This fixes that.

I also added tracking of state that affects sorting/filtering to reduce the amount of work needed between renders.


Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

@bitbound bitbound self-assigned this Aug 31, 2023
@bitbound bitbound changed the base branch from master to tech/platform-guards August 31, 2023 17:05
colinblaise
colinblaise previously approved these changes Sep 1, 2023
Base automatically changed from tech/platform-guards to master September 1, 2023 13:43
@bitbound bitbound dismissed colinblaise’s stale review September 1, 2023 13:43

The base branch was changed.

@bitbound bitbound merged commit 08955cf into master Sep 1, 2023
@bitbound bitbound deleted the bug/fix-device-filtering branch September 1, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants