fix: warn host has been deprecated in favor of domain

[ericdeansanchez]

The purpose of this PR is to warn users that host has been deprecated
in favor of domain.

[sherwinski]

Sorry, one last thing. Can we also update the README calling out the deprecation and how to resolve it?

Everything else looks great 👍

[ericdeansanchez]

@sherwinski Yeah, I was going to ask about that. Do you feel this is all coherent? I.e. domain getting reassigned to host, a warning is emitted each time host is used, but only through initialize.

This brings me to if domain is to be used, and [all?] references in the README are to be changed from host to domain, but really @host is the instance variable then anyone accessing client.domain might be getting something unexpected back, no?

Updating the readme and the above concern are separate matters for the most part; I had thought of the former but got sidetracked by the latter.

[sherwinski]

@sherwinski Yeah, I was going to ask about that. Do you feel this is all coherent? I.e. domain getting reassigned to host, a warning is emitted each time host is used, but only through initialize.

This brings me to if domain is to be used, and [all?] references in the README are to be changed from host to domain, but really @host is the instance variable then anyone accessing client.domain might be getting something unexpected back, no?

Updating the readme and the above concern are separate matters for the most part; I had thought of the former but got sidetracked by the latter.

Just to close the loop on this: we settled on assigning an instance field @domain during init, in the case that users do try to access it.

[ericdeansanchez]

@sherwinski I think I jumped the gun on the @host = @domain stuff. Totally missed that there were no accessors defined for @host to begin with 🙃 😬 🙃 TL;DR: we're good ha