Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ensure even requirement #69

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

ericdeansanchez
Copy link
Contributor

@ericdeansanchez ericdeansanchez commented May 18, 2020

This PR removes the ensure even requirement on target widths and
updates the appropriate tests.

Previously, image target widths were required to be even integer values.
The original line of thought accounted for physical device pixel dimension
evenness; however, this is important only if images are rendered at full
viewport width.

Since this is not always the case, we wanted to include both odd and even
values here to give users more flexibility and to better meet user expectations:
i.e. if widths [115, …, 2121] were requested, then [116, …, 2122] could be
considered unexpected.

@ericdeansanchez ericdeansanchez merged commit d929ad9 into master May 19, 2020
@ericdeansanchez ericdeansanchez deleted the remove-ensure-even branch May 19, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants