refactor: pass srcset modifiers through the options
parameter
#57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how the new srcset modifier options (see #54, #55, and #56) are required to be passed to
Imgix::Path#to_srcset
. Instead of passing values directly throughwidths
,width_tolerance
,min_srcset
, and/ormax_srcset
keyword parameters, users should now store any combination of these arguments in the newoptions
parameter as a hash.This change is being made to avoid confusion in naming between imgix URL parameters and parameters that modify object behavior. This should hopefully clarify through design of the interface which options modify how srcsets are generated versus how the image itself is modified through imgix's service.
Example:
Will output the following: