Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(travis): change build dist to trusty and remove bundler script #49

Merged
merged 7 commits into from
Sep 5, 2019

Conversation

sherwinski
Copy link
Contributor

@sherwinski sherwinski commented Aug 30, 2019

At the time of writing, travis is not able to run builds using non-standard ruby interpreters, of which we currently test against jruby and rbx (or rubinius). Other users have noted that it may be linked to travis switching the default builds to use ubuntu xenial, which at this point doesn't have access to the same binaries as the previously-used trusty. Two possible solutions are to either set the test environment to an older ubuntu version or to temporarily remove rbx in the meantime until the binaries become available.

Unrelated to this issue, this PR also undoes changes made in #41 seeing as how travis is now better at choosing which version of bundler to build with.

@sherwinski sherwinski requested a review from jayeb August 30, 2019 22:48
@jayeb
Copy link
Contributor

jayeb commented Aug 30, 2019

Ruby interpreters aren't exactly an area of expertise for me. What kind of impact can we expect this change to have on projects that depend on this Gem?

@sherwinski
Copy link
Contributor Author

At the moment none since this is only to supplement our own development. But until this gets fixed, travis won't alert us if any new changes don't play nice with rbx. We could also run the tests locally in rbx as an extra precaution before pushing.

@sherwinski
Copy link
Contributor Author

I've decided to opt for setting dist: trusty (in lieu of the default xenial) so as to keep coverage for jruby and rbx. The main reason being that it's currently the suggested way to test rbx according to the travis documentation. I do see this issue mentioned elsewhere but will have to follow up with travis separately to get an idea of when we can expect a complete fix.

@sherwinski sherwinski changed the title ci(travis): remove rbx build and bundler script ci(travis): change build dist to trusty and remove bundler script Sep 4, 2019
@sherwinski sherwinski merged commit f424583 into master Sep 5, 2019
@sherwinski sherwinski deleted the travis-fix-jruby-rbx branch September 5, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants