fix: deprecate domain sharding #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2019 16:33
sherwinski
commented
Apr 23, 2019
| @@ -59,7 +60,9 @@ def host_for_crc(path) | |||
| end | |||
|
|
|||
| def host_for_cycle | |||
| @hosts_cycle = @hosts.cycle unless @hosts_cycle | |||
There was a problem hiding this comment.
Incidentally, this line was throwing an initialization warning that got in the way when we used assert_output to check for the expected deprecation warning.
jayeb
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the process of deprecating, and eventually removing, domain sharding from the imgix-rb library.
The
Imgix::Clientobject will now throw a warning when users attempt to initialize it by passing in multiple domains in the form of an array.