fix: encode web proxy paths using url_encode #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the encoding function used on web proxy paths from
CGI.escape
toERB::Util.url_encode
, which is the same function used for general path encoding in this library. Because this library usesCGI.escape
to encode a web proxy path, it encodes spaces as+
rather than%20
(due to following the CGI/HTML form spec). However, encoding in this way results in URLs that do not resolve properly. More details can be found in this SO discussion.See test below with active source: