Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use optimistic versioning #107

Merged
merged 2 commits into from
Apr 6, 2021
Merged

ci: use optimistic versioning #107

merged 2 commits into from
Apr 6, 2021

Conversation

sherwinski
Copy link
Contributor

@sherwinski sherwinski commented Apr 5, 2021

This PR changes the Ruby versions tested by Travis to use optimistic versioning.

I tried to add a build for Ruby 3.0 but there is an issue where Travis does not import the proper GPG keys for RVM prior to attempting to install Ruby. (Explored in rvm/rvm#4561)
I suggest waiting until this issue is resolved before adding a test for Ruby version 3.0 and later.

@commit-lint
Copy link

commit-lint bot commented Apr 5, 2021

Continuous Integration

  • use optimistic versioning (b1b443c)
  • use major version only for Rubinius 3 (1b8d5c8)

Contributors

sherwinski

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@sherwinski sherwinski marked this pull request as ready for review April 6, 2021 18:32
@sherwinski sherwinski requested a review from a team as a code owner April 6, 2021 18:32
Copy link
Contributor

@luqven luqven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@sherwinski sherwinski merged commit 921e41a into main Apr 6, 2021
@sherwinski sherwinski deleted the update-ci branch April 6, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants