perf: precompute DEFAULT_TARGET_WIDTHS to avoid repeating the work in client.path(..) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Path.new` or `client.path(..)` re-computes the same default target
widths on each call. It can be computed once on boot rather than with
each `client.path` call. The `@default_target_width` might not actually
be used if srcsets aren't being generated and `widths` isn't specified,
so it doesn't make sense to perform this work in the initializer.
Before:
```
❯ be ruby script/bench_path.rb
Warming up --------------------------------------
Imgix::Path#initialize
19.625k i/100ms
Calculating -------------------------------------
Imgix::Path#initialize
195.167k (± 0.7%) i/s - 981.250k in 5.027994s
```
After:
```
❯ be ruby script/bench_path.rb
Warming up --------------------------------------
Imgix::Path#initialize
107.620k i/100ms
Calculating -------------------------------------
Imgix::Path#initialize
1.067M (± 0.9%) i/s - 5.381M in 5.045179s
```
Performance Improvements
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
ericdeansanchez
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
We could also omit the call to TARGET_WIDTHS.call altogether if we generate and assign the DEFAULT_TARGET_WIDTHS once (i.e. just an array of 31 values [100, ..., 8192]). The only issue with this is remembering to update this array (maybe the min/max/tolerance defaults change). To solve for that, we could test that the DEFAULT_TARGET_WIDTHS = [...] array is the same as calling TARGET_WIDTHS.call(DEFAULT_WIDTH_TOLERANCE, MIN_WIDTH, MAX_WIDTH). Just my 2¢
Otherwise this lgtm 👍
sherwinski
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Thanks for this @stevehodgkiss! Definitely a marked improvement 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Path.new/client.path(..)re-computes the same default targetwidths on each call. It can be computed once on boot rather than with
each
client.pathcall. The@default_target_widthmight not actuallybe used if srcsets aren't being generated and
widthsisn't specified,so it doesn't make sense to perform this work in the initializer.
Before:
After: