Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dpr srcset when only h param #76

Merged
merged 4 commits into from
Mar 10, 2021
Merged

fix: dpr srcset when only h param #76

merged 4 commits into from
Mar 10, 2021

Conversation

luqven
Copy link
Contributor

@luqven luqven commented Mar 8, 2021

Description

This PR ensures a DPR-based SrcSet is generated when a fixed height is the only parameter value.

It removes tests that no longer apply to only having h as a param, and
adds tests that ensure the DPR sercset was generated correctly.

@luqven luqven self-assigned this Mar 8, 2021
@commit-lint
Copy link

commit-lint bot commented Mar 8, 2021

Bug Fixes

  • address issue where h only srcsets did not respect ar (e21140c)

Tests

  • add h based srcset tests and comment out deprecated tests (05a2a1f)
  • remove comments and add testHeightIncludesDPRParam (fe0ee3e)

Chore

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@luqven luqven marked this pull request as ready for review March 8, 2021 15:10
@luqven luqven requested a review from a team as a code owner March 8, 2021 15:10
frederickfogerty
frederickfogerty approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@ericdeansanchez
Copy link
Contributor

👍

sherwinski
sherwinski suggested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just remembered that this change also needs to be reflected in the project documentation at some point, either in this PR or a separate one.

@luqven luqven mentioned this pull request Mar 9, 2021
Merged
@luqven luqven merged commit b192648 into main Mar 10, 2021
@luqven luqven deleted the luis/fixSrcsetWhenHParam branch March 10, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherwinski sherwinski sherwinski requested changes

@frederickfogerty frederickfogerty frederickfogerty approved these changes

Assignees

@luqven luqven

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luqven @ericdeansanchez @frederickfogerty @sherwinski