fix: add domain validation at UrlBuilder initialization #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherwinski
force-pushed
the
domain-validation
branch
from
4b6c565 to
ca8d713
Compare
jayeb
suggested changes
Apr 8, 2019
sherwinski
force-pushed
the
domain-validation
branch
from
ca8d713 to
135989a
Compare
jayeb
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a validation that will throw an error if a user attempts to initialize a new
UrlBuilderobject with an invalid domain.The validation criteria is based off of the same regex used on dashboard.imgix.com
Fixes #10