Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated phpunit annotations with exception methods #39

Merged
merged 1 commit into from
Apr 4, 2019
Merged

fix: replace deprecated phpunit annotations with exception methods #39

merged 1 commit into from
Apr 4, 2019

Conversation

sherwinski
Copy link
Contributor

This PR replaces the deprecated @expectedException and @expectedExceptionMessage annotations with the preferred exception method equivalents.

@sherwinski sherwinski requested a review from nathan-heskia April 4, 2019 22:27
nathan-heskia
nathan-heskia approved these changes Apr 4, 2019
View reviewed changes
Copy link

@nathan-heskia nathan-heskia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sherwinski sherwinski merged commit e192dbd into master Apr 4, 2019
@sherwinski sherwinski deleted the replace-deprecated-annotations branch April 4, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-heskia nathan-heskia nathan-heskia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherwinski @nathan-heskia