Refactor client-hints, add Permissions-Policy#12
Merged
Conversation
Collaborator
|
Permission policy does not seem to work... It doesn't delegate the hints to imageengine. When I removed the permission haeader, and left the feature policy in, it worked. PP seems to be bleeding edge. Good catch though! Was not aware of its inclusion in v88 |
Collaborator
|
Ah. " missing. |
Member
Author
|
Nice, thanks for testing that, I have a small update to push that cleans up some code and then I'll test it as well and we can create a new version. |
kamermans
commented
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks the Client-Hints / CORS-support headers so all code uses the same set of client-hints.
It also implements
Permissions-Policy, the replacement forFeature-Policyas of Chrome 88For more info see: