Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll selected sidebar entry into view #471

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

yuri1969
Copy link
Contributor

Long sidebars did not scroll to show the selected entry. This made working with such long sidebars quite confusing.

QAed using 10+ copies of exampleSite/content/docs/guide/shortcodes/callout.md.

Fixes #395

Long sidebars did not scroll to show the selected entry. This made
working with such long sidebars quite confusing.
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit 22c10af
🔍 Latest deploy log https://app.netlify.com/sites/hugo-hextra/deploys/670a37de34ce0d00082035aa
😎 Deploy Preview https://deploy-preview-471--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuri1969 looks great, thanks for the contribution!

@imfing imfing changed the title feat: make selected sidebar entry visible feat: scroll selected sidebar entry into view Oct 12, 2024
@imfing imfing merged commit 97ea671 into imfing:main Oct 12, 2024
4 checks passed
@yuri1969 yuri1969 deleted the scroll-to-selected branch October 12, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make selected entry in sidebar always visible
2 participants