Support optional x264 dependency #7
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haileys
commented
May 1, 2020
| [dependencies] | ||
| libc = "^0.2" | ||
| num_cpus = "1.11.1" | ||
| x264-dev = { path = "../x264-dev", optional = true } |
There was a problem hiding this comment.
This relies on unmerged/unreleased changes upstream in imager-io/x264-dev#1 and needs to be pointed at a released version before we can merge this PR
|
Interesting, initially when I wrote this library it was for the purpose of container muxing/demuxing and general decoding, and so in conjunction with keeping it self contained I never thought about supporting x264 for AVC encoding. Also seemed like I would be implementing the build stuff twice rather than use the x264 crate as you proposed. Nice work :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional support for x264. It's disabled by default for licensing reasons, so users of this crate must opt in to x264 support by enabling the
gplandx264features.This pull request depends on the pkgconfig manifest PR over at imager-io/x264-dev#1