Skip to content

Conversation

@amanforindia
Copy link
Contributor

No description provided.

KhushbooMer and others added 26 commits July 12, 2022 18:39
… details, get file versions, update file details etc
@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2022

This pull request introduces 5 alerts and fixes 2 when merging 76e8cdc into b89c243 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 2 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2022

This pull request introduces 17 alerts and fixes 2 when merging a2991ff into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2022

This pull request introduces 17 alerts and fixes 2 when merging 604de8f into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2022

This pull request introduces 17 alerts and fixes 2 when merging 483404f into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2022

This pull request introduces 17 alerts and fixes 2 when merging cbeb0e6 into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2022

This pull request introduces 17 alerts and fixes 2 when merging 8edb05d into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2022

This pull request introduces 17 alerts and fixes 2 when merging 87e16a8 into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

Copy link
Member

@ahnv ahnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagekitio.constants and imagekitio.utils should be modules and should include init.py which are missing in both folders

Getting the following errors, adding init.py files to both constants and utils folder fixes it
image
image

Copy link
Contributor

@imagekitio imagekitio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signed URL generated is not working because the overlay images are not found
// Line 169

image_url = imagekit.url(
{
"path": upload.file_path,
"query_parameters": {"v": "123"},
"transformation": [
{
"overlay_image": "/demo1/new_car.jpg",
"default_image": "/demo1/default-image.jpg",
}
],
"signed": True,
"expire_seconds": 3000,
}
)

Geneated URL: https://ik.imagekit.io/gutwwp86o/tr:oi-demo1@@new_car.jpg,di-demo1@@default-image.jpg/testing-python-folder/._sample_file.jpg?v=123&ik-t=1664430023&ik-s=2b05c59a0c3458e9f6c25743a570b4360afbe740

ik-error: ENOENT - Default image also not found

Expectation: all the URL's generated by the Sample App, should work out on the first execution of the sample app

Copy link
Contributor

@imagekitio imagekitio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of commented code in the sample app Line 679 to 717

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2022

This pull request introduces 17 alerts and fixes 2 when merging ba38bb8 into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 30, 2022

This pull request introduces 17 alerts and fixes 2 when merging 013b26d into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@lgtm-com
Copy link

lgtm-com bot commented Sep 30, 2022

This pull request introduces 17 alerts and fixes 2 when merging 0904e9d into d0cd96b - view on LGTM.com

new alerts:

  • 7 for Membership test with a non-container
  • 6 for Unused import
  • 2 for Non-iterable used in for loop
  • 1 for Nested loops with same variable
  • 1 for Nested loops with same variable reused after inner loop body

fixed alerts:

  • 1 for Unused local variable
  • 1 for Duplicate key in dict literal

@imagekitio imagekitio merged commit 38e50cc into imagekit-developer:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants