Skip to content

Adds implementation for test checking if file is deleted #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds implementation for test checking if file is deleted #4

wants to merge 1 commit into from

Conversation

frauzufall
Copy link
Member

The current webdav uploader has a reflection hack overriding the default GET method of a HTTP request by special ones like DELETE or OPTIONS. For HTTPS, this hack does not work. Therefore, when assuming the DELETE method is called, the GET method is called instead. In case the file is present, it returns 200 - all good. The test is assuming deleting worked and continues..

  • by checking if a file is actually deleted, AbstractUploaderTestBase.test() will now fail for HTTPS
  • removes unused import

@frauzufall
Adds implementation for test checking if file is deleted
5ca4b8c 
* depends on imagej/imagej-updater#73
* by checking if a file is actually deleted,
AbstractUploaderTestBase.test() will now fail for HTTPS (because
uploading does not work there yet)
* removes unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@frauzufall