Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ffmpeg suitable for Apple Silicon macos arm64 platform #114

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GenevieveBuckley
Copy link

Closes #71

This PR follows the approach suggested in #71 (comment)

  • Update _definitions.py
    • Make sure the apple silicon platform is detected by get_platform().
    • Add new exe file name to FNAME_PER_PLATFORM.
    • Add entry to WHEEL_BUILDS.

Stilll required:

This comment suggests http://www.osxexperts.net/ is a reliable source for the ffmpeg binary. Example ffmpeg download:

wget https://www.osxexperts.net/ffmpeg7arm.zip
unzip ffmpeg7arm.zip
mv ffmpeg ffmpeg-osx-arm64-v7
shasum -a 256 ffmpeg
# Expected SHA256 checksum
# 326895b16940f238d76e902fc71150f10c388c281985756f9850ff800a2f1499

# https://github.com/imageio/imageio-ffmpeg/issues/71#issuecomment-1549677710
# "Although it is not notarized, so I had to run xattr -c ffmpeg to bless it"
xattr -c ffmpeg-osx-arm64-v7

@GenevieveBuckley GenevieveBuckley marked this pull request as draft June 4, 2024 03:02
@GenevieveBuckley
Copy link
Author

Marking as draft PR, until the ffmpeg binary for macos arm64 is uploaded.

@almarklein
Copy link
Member

I added the ffmpeg MacOS executable for Silicon: imageio/imageio-binaries@66322a9. Added the same version for x86 for good measure. Their names are: ffmpeg-osx-arm64-v7.0 and ffmpeg-osx-x86-v7.0.

@GenevieveBuckley GenevieveBuckley marked this pull request as ready for review June 6, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ffmpeg not included in wheel for MacOS M1
2 participants