-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add immich-healthcheck #485
base: openvino
Are you sure you want to change the base?
Conversation
I am a bot, here are the test results for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want to maintain this script, if this is just a copy of the upstream script, just copy it when building the image and add of soft link to /root/usr/local/bin/immich-healthcheck
Lines 73 to 77 in fc199ad
echo "**** copy scripts ****" && \ | |
cd /tmp/immich/docker && \ | |
cp -r \ | |
scripts \ | |
/app/immich/server && \ |
I can't remember exactly why, but upstream has disabled the healtcheck by default, IMO it should be the same.
I believe it would just be best to mention a healthcheck can be added to the docker compose and probe |
Actually, I also created a modified version by copying server/bin/immich-healthcheck and then creating a symlink. Later, I figured that immich-healthcheck probably wouldn't change, so I just copied it directly for use. I noticed in the source code (https://github.com/immich-app/immich/blob/main/server/Dockerfile) that the healthcheck is enabled by default, but in the docker-compose file (https://github.com/immich-app/immich/blob/main/docker/docker-compose.prod.yml), the healthcheck is disabled by default. That's why I thought of documenting the healthcheck in the README. |
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
copy this file (https://github.com/immich-app/immich/blob/main/server/bin/immich-healthcheck)