fix: correct text alpha blending #719
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx draw text with alpha.
The previous version of the function added a white outline to the text. When attempting to render semi-transparent text (e.g., using alpha = 125), the text ended up cutting out the background instead of blending with it.
See the examples below:
— The top label is rendered using the old function.
— The bottom label shows the result after my changes.
Suggestions:
To compute a
has_alpha: bool
flag, I based my logic on this.It may be useful to expose this logic via
Pixel::has_alpha()
method inside theimage
crate