Add support for parsing cICP
chunks.
#529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is needed for parity with the existing PNG decoder in Blink / Chromium - see https://crbug.com/376758571.
I think that we should opaquely return
u8
forcolor_primaries
andtransfer_function
. Being opaque will help with extensibility (in case ITU-T-H.273 gets augmented in the future with other table entries / configurations).I am less sure about the other 2 fields:
matrix_coefficients
asu8
and return it even though the parser rejects anything other than 0 (same asblink::PNGImageDecoder
in Chromium - see here).video_full_range_flag
as anenum
.