-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Nullable values in line chart #252
Conversation
…to follow instructors
there are formatting changes again because of the last PR. contributor did not use dart formatter at all |
I'll add a linter check to verify it in each PR. |
…s need to follow instructors This reverts commit fc5974d.
Thank you, |
@imaNNeoFighT Unrelated to this PR but this is what happens on master right now when I provide spots: const [
FlSpot(0, 1),
FlSpot(11, 4),
FlSpot(2, 1),
FlSpot(4.9, 5),
FlSpot(6.8, 5),
FlSpot(8, 1),
FlSpot(9.5, 2),
], Should the spots be sorted or would that be incorrect for a line chart? It seems to be the |
Ok all set. Just ignore my last comment, it's unrelated. |
About your last comment, I think it's correct :) |
I've made some changes on your codes, they are for simplification check the commit here. |
This PR provides the ability for a user to provide null points on the line chart to achieve gaps in data.
FlSpot(null,null)
Sample has been updated. It's not pretty but it demonstrates a lot of different stuff.
Closes #26
Closes #123