-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/horizontal bar chart #1827
Open
imaNNeo
wants to merge
12
commits into
main
Choose a base branch
from
feature/horizontal-bar-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CleanShot.2024-12-26.at.22.42.45.mp4 |
CleanShot.2024-12-26.at.22.46.20.mp4 |
CleanShot.2024-12-26.at.22.49.47.mp4 |
imaNNeo
changed the title
WIP: Feature/horizontal bar chart
WIP: Feature/horizontal bar/line/scatter chart
Dec 26, 2024
imaNNeo
changed the title
WIP: Feature/horizontal bar/line/scatter chart
WIP: Feature/horizontal bar chart
Dec 26, 2024
imaNNeo
force-pushed
the
feature/horizontal-bar-chart
branch
from
December 27, 2024 12:17
4d78e94
to
ade5115
Compare
…xisSide This way, we have more access to the TitleMeta properties.
imaNNeo
force-pushed
the
feature/horizontal-bar-chart
branch
from
December 27, 2024 12:34
3493f3a
to
e70548d
Compare
…o have rotated charts for bar_chart (Horizontal Bar Chart), line_chart and scatter chart
…ip texts upward always)
imaNNeo
force-pushed
the
feature/horizontal-bar-chart
branch
from
December 27, 2024 12:36
e70548d
to
9918c94
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
+ Coverage 93.20% 93.43% +0.23%
==========================================
Files 45 46 +1
Lines 3236 3261 +25
==========================================
+ Hits 3016 3047 +31
+ Misses 220 214 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… the analysis issues
…ationQuarterTurns is 2 in the line_chart (because it is top down)
imaNNeo
force-pushed
the
feature/horizontal-bar-chart
branch
from
December 27, 2024 15:15
e50d527
to
4c96d1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added the Horizontal Bar Chart feature.
So simply, we have a new parameter called
rotationQuarterTurns
and it works exactly like how RotatedBox works. (Actually, we use RotatedBox under the hood)Fixes #113