added axis titles #115

j4nk3e · 2019-11-19T11:54:24Z

I implemented the possibility to add axis descriptions to the line charts.
You can add text to each axis on the left, right, top and bottom, which will be shown outside of the current axis titles.

imaNNeo · 2019-11-27T07:37:59Z

Hi there,
any news?

j4nk3e · 2019-11-27T07:43:30Z

Do you need anything to handle this PR?

imaNNeo · 2019-11-27T07:50:01Z

Did you see my comment?

j4nk3e · 2019-11-27T07:59:41Z

0 comments on commit cf18909 nope, sry

imaNNeo · 2019-11-20T20:03:31Z

example/lib/line_chart/samples/line_chart_sample5.dart

@@ -38,7 +38,8 @@ class LineChartSample5 extends StatelessWidget {
            return MapEntry(
              index,
              [
-                LineBarSpot(tooltipsOnBar, lineBarsData.indexOf(tooltipsOnBar), tooltipsOnBar.spots[index]),
+                LineBarSpot(tooltipsOnBar, lineBarsData.indexOf(tooltipsOnBar),


Hi there, really nice to see your PR.
Please prevent to commit these kinds of reformats.
It makes the review hard, and also some redundant changes, please revert all of the changes due to reformat, then I will review it and I will merge it.
Thanks!

imaNNeo · 2019-11-27T08:02:08Z

Sorry man, I didn't submit it.
Check it out.
Thanks!

j4nk3e · 2019-11-27T08:55:26Z

Of course. My AS is configured to run dartfmt on save.
I updated the commit without formatting.

imaNNeo · 2019-11-30T13:47:21Z

Hi @juumixx,
I've just reviewed your code and everything looks good, I appreciate it, it is perfect.
May I ask you to implement it in BarChart and ScatterChart too, for the sake of consistency?

imaNNeo · 2019-11-30T13:47:40Z

also please rebase your branch to retrieve the ScatterChart.

imaNNeo · 2019-12-05T21:45:17Z

Hello??

j4nk3e · 2019-12-06T13:22:17Z

Hi, sorry I didn't have the time yet to look into the other charts. I will try to build it into the other charts, too.

imaNNeo · 2019-12-06T13:34:54Z

Thanks man!
Waiting for you.

j4nk3e · 2019-12-10T13:21:20Z

I updated my branch and am working on integrating the axis titles to the bar charts now.

imaNNeo · 2019-12-10T13:26:33Z

Thanks!

j4nk3e · 2019-12-10T13:38:04Z

Actually, I'm moving it up to the AxisChartPainter, so it should also work for the ScatterChart

… when show/hide is toggled

j4nk3e · 2019-12-10T14:23:52Z

I still added an example to the scatter charts. I think it is ready to merge now.

imaNNeo · 2019-12-10T19:48:24Z

Thanks, man, I'm gonna review it.

imaNNeo · 2019-12-10T22:10:11Z

And again thank you for this great feature.
I've tested it and it is working, I appreciate it.
Waiting for your changes, I promise I will merge it ASAP.
Thanks!

j4nk3e · 2019-12-11T09:17:16Z

Did you leave comments somewhere in the code?

imaNNeo · 2019-12-11T11:20:03Z

Yes but I forgot to submit them, sorry about that.

lib/src/chart/base/base_chart/base_chart_data.dart

lib/src/chart/base/axis_chart/axis_chart_painter.dart

example/lib/bar_chart/samples/bar_chart_sample2.dart

imaNNeo · 2019-12-14T09:41:40Z

Hello, how's it going?
I'm waiting for you to resolve these comments then I will merge this wonderful feature.
Thanks!

j4nk3e · 2019-12-16T12:29:51Z

Thanks for the review. We still have to finish a release until Christmas, but maybe I'll get to fixing the issues on Friday.

imaNNeo · 2019-12-16T18:47:47Z

Ok, thanks for the update.

j4nk3e · 2019-12-20T14:51:52Z

I updated the PR.
Do you think it's ok to leave the painter implementation like it is (#115 (comment))?

imaNNeo · 2019-12-20T21:42:15Z

Yes, leave it there.
May I ask you to update this documentation? and update the samples image here?
Thanks, man.

UPDATE:
and also all of Line, Bar, Scatter chart documentations.

j4nk3e · 2019-12-23T14:31:59Z

Will do

imaNNeo · 2019-12-26T17:52:25Z

Hi there,
any news?

j4nk3e · 2019-12-30T10:39:16Z

Voilà!

imaNNeo · 2019-12-30T21:29:36Z

Yay, congrats!
waiting for your next contributions.
Thanks a lot :)

j4nk3e · 2020-01-02T16:55:25Z

Thanks :D
More is coming soon.

kaarens93 · 2020-01-03T01:48:29Z

Hi, I am still having trouble with displaying the axis titles. 'axisTitleData' not defined

j4nk3e · 2020-01-03T10:27:34Z

Hi @kaarens93
Can you please open an issue and provide us with example code to reproduce the issue?

kaarens93 · 2020-01-03T17:39:33Z

@juumixx hi, I just opened an issue. Thank you! I am sure I'm overlooking something small.

imaNNeo reviewed Nov 27, 2019

View reviewed changes

j4nk3e force-pushed the axis-titles branch from cf18909 to 9f722d1 Compare November 27, 2019 08:53

added axis titles (without formatting)

267d9c1

j4nk3e force-pushed the axis-titles branch from 9f722d1 to 267d9c1 Compare December 10, 2019 12:41

j4nk3e added 2 commits December 10, 2019 14:55

moved axis titles to axis chart painter and added example for bar chart

e951af8

added example for scatter chart axis titles and fixed axis title lerp…

009eccf

… when show/hide is toggled

imaNNeo reviewed Dec 11, 2019

View reviewed changes

review changes

158da72

revert axis title example changes

7d5713f

added axis title documentation and updated screenshots

4012978

imaNNeo merged commit 1cf6723 into imaNNeo:master Dec 30, 2019

j4nk3e deleted the axis-titles branch January 3, 2020 09:41

BaronTryBest mentioned this pull request Nov 17, 2021

Flutter project ScatterChart Release crash on iPhone #812

Closed

sk784 mentioned this pull request Jun 9, 2022

Throws exception if number of points on the x-axis = 1 #1053

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added axis titles #115

added axis titles #115

j4nk3e commented Nov 19, 2019

imaNNeo commented Nov 27, 2019

j4nk3e commented Nov 27, 2019

imaNNeo commented Nov 27, 2019

j4nk3e commented Nov 27, 2019

imaNNeo Nov 20, 2019

imaNNeo commented Nov 27, 2019

j4nk3e commented Nov 27, 2019

imaNNeo commented Nov 30, 2019

imaNNeo commented Nov 30, 2019

imaNNeo commented Dec 5, 2019

j4nk3e commented Dec 6, 2019

imaNNeo commented Dec 6, 2019

j4nk3e commented Dec 10, 2019

imaNNeo commented Dec 10, 2019

j4nk3e commented Dec 10, 2019

j4nk3e commented Dec 10, 2019

imaNNeo commented Dec 10, 2019

imaNNeo commented Dec 10, 2019

j4nk3e commented Dec 11, 2019

imaNNeo commented Dec 11, 2019

imaNNeo commented Dec 14, 2019

j4nk3e commented Dec 16, 2019

imaNNeo commented Dec 16, 2019

j4nk3e commented Dec 20, 2019

imaNNeo commented Dec 20, 2019 •

edited

Loading

j4nk3e commented Dec 23, 2019

imaNNeo commented Dec 26, 2019

j4nk3e commented Dec 30, 2019

imaNNeo commented Dec 30, 2019

j4nk3e commented Jan 2, 2020

kaarens93 commented Jan 3, 2020

j4nk3e commented Jan 3, 2020

kaarens93 commented Jan 3, 2020

added axis titles #115

added axis titles #115

Conversation

j4nk3e commented Nov 19, 2019

imaNNeo commented Nov 27, 2019

j4nk3e commented Nov 27, 2019

imaNNeo commented Nov 27, 2019

j4nk3e commented Nov 27, 2019

imaNNeo Nov 20, 2019

Choose a reason for hiding this comment

imaNNeo commented Nov 27, 2019

j4nk3e commented Nov 27, 2019

imaNNeo commented Nov 30, 2019

imaNNeo commented Nov 30, 2019

imaNNeo commented Dec 5, 2019

j4nk3e commented Dec 6, 2019

imaNNeo commented Dec 6, 2019

j4nk3e commented Dec 10, 2019

imaNNeo commented Dec 10, 2019

j4nk3e commented Dec 10, 2019

j4nk3e commented Dec 10, 2019

imaNNeo commented Dec 10, 2019

imaNNeo commented Dec 10, 2019

j4nk3e commented Dec 11, 2019

imaNNeo commented Dec 11, 2019

imaNNeo commented Dec 14, 2019

j4nk3e commented Dec 16, 2019

imaNNeo commented Dec 16, 2019

j4nk3e commented Dec 20, 2019

imaNNeo commented Dec 20, 2019 • edited Loading

j4nk3e commented Dec 23, 2019

imaNNeo commented Dec 26, 2019

j4nk3e commented Dec 30, 2019

imaNNeo commented Dec 30, 2019

j4nk3e commented Jan 2, 2020

kaarens93 commented Jan 3, 2020

j4nk3e commented Jan 3, 2020

kaarens93 commented Jan 3, 2020

imaNNeo commented Dec 20, 2019 •

edited

Loading