Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added powershell command #98

Merged
merged 1 commit into from
Sep 16, 2021
Merged

✨ Added powershell command #98

merged 1 commit into from
Sep 16, 2021

Conversation

kaffarell
Copy link
Contributor

@kaffarell kaffarell commented Sep 16, 2021

The curl command on the page does not work on windows (altough curl is
installed on windows) so I added a native windows powershell command.

  • 🐛 Fixed titles
    changed from bold to h2 because it looks nicer

Resolves: #78 #98

@kaffarell kaffarell changed the title ✨ Added powershell command, fixes ✨ Added powershell command Sep 16, 2021
@imRohan imRohan self-requested a review September 16, 2021 12:13
@imRohan imRohan added the Ready for Review Once you've squashed your commits, the PR is now ready for review! label Sep 16, 2021
Copy link
Owner

@imRohan imRohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just squash your commits / edit the PR & commit message and ill merge this one in. 👏

The curl command on the page does not work on windows (altough curl is
installed on windows) so I added a native windows powershell command.

* 🐛 Fixed titles
	changed from bold to h2 because it looks nicer

Resolves: #78 #98
@kaffarell
Copy link
Contributor Author

@imRohan Finished the changes 🙌

@imRohan imRohan self-requested a review September 16, 2021 13:33
Copy link
Owner

@imRohan imRohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@imRohan imRohan merged commit d2df5d8 into imRohan:master Sep 16, 2021
@kaffarell kaffarell deleted the fix/powershell_request branch September 17, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review Once you've squashed your commits, the PR is now ready for review!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Curl post request command not working in powershell
2 participants