Migrating from tslint to eslint #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @imRohan I finished the tslint to eslint migration. I don't know if you agree with this code-style, but hit me up if you need any change. I configured eslint so that any variable with an implicit or explicit any type is reported as a warning (The goal should be that everything is typed). |
imRohan
requested changes
Sep 14, 2021
imRohan
added
the
Ready for Review
imRohan
requested changes
Sep 16, 2021
* 🚨 Migrated from tslint to eslint * 🔧 Fixed a few eslint errors * 🔧 Fixed most of the linter errors and settings Fixed the easily fixable linter errors like trailing whitespace. Next up is typing. * 🔧 Finalized eslint installation, fixed package.json scripts Also removed tslint * 🔧 Fixed eslint brace-style rule allowSingleLine for braces * 🔧 Removed comments from config file, fixed typo Fixes: #88, #95 🔧 Removed comments from config file, fixed typo
|
@imRohan Finished changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Migrated from tslint to eslint
Because tslint is deprecated now
Fixed the easily fixable linter errors like trailing whitespace. Next up is typing.
Also removed tslint
allowSingleLine for braces
Resolves: #88 #95