Status page: Display total number of accounts #84
Conversation
|
@AnnikaCodes Awesome work, ill get to reviewing this shortly. I'm curious why the Github Workflow hasn't run properly yet. Can you push an empty commit |
|
Do you need to approve it? When using GitHub Actions on other repositories, I've had to manually approve the CI run for first-time contributors. |
I merged in the latest changes from master which lets the CI action run on pull requests. Could you please squash all of the commits into one please? Thanks! |
|
Sure, I'll squash it and also fix the linter errors while I'm at it. |
|
There's still one linter failure locally, but it's because |
As described in #59, this publicized the current number of active accounts/pantries. I don't know how big Pantry is or how much traffic you get; it might make sense to cache the total number of accounts, although I'm not familiar enough with Redis to know how to mark that cache as stale when Redis marks a key as expired (though it's probably not a huge deal if old accounts are included in the tally for a bit?). Anyway, this seems like an intriguing project and I look forward to helping out more!
imRohan
added
Ready for Review
|
@AnnikaCodes Just a heads up but this is now live on production 🎉 |
|
Nice! |
Displays the total number of accounts on the status page
This provides transparency about how many people use Pantry (and by extension, gives users an idea of how much time and money goes into maintaining it).
getTotalNumber()method to theAccountclassaccount:*-*-*-*-[a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9][a-z0-9]to match 'account:' followed by a UUID, with nothing after it.totalAccountfield to theISystemStatusinterface.scan()method to the data store service, which allows use of the Redis commandSCAN.Partially resolves #59