Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Basket Modify Request Method to POST #152

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Conversation

imRohan
Copy link
Owner

@imRohan imRohan commented Mar 27, 2022

Users should be able to update the contents of the basket entirely via
the dashboard. Currently, the dashboard uses a put to add/edit the
contents of the basket. However, users would probably like to have full
control and overwrite the entirety of a basket's content if they wish.

This change addresses the need by:

  • Updating the request method from PUT to POST

Resolves #150

@imRohan imRohan added the Ready for Review Once you've squashed your commits, the PR is now ready for review! label Mar 27, 2022
@imRohan imRohan self-assigned this Mar 27, 2022
Users should be able to update the contents of the basket entirely via
the dashboard. Currently, the dashboard uses a put to add/edit the
contents of the basket. However, users would probably like to have full
control and overwrite the entirety of a basket's content if they wish.

This change addresses the need by:
* Updating the request method from PUT to POST

Resolves #150
@imRohan imRohan merged commit 772268e into master Mar 27, 2022
@imRohan imRohan deleted the rl-update-basket-method branch March 27, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Review Once you've squashed your commits, the PR is now ready for review!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating a basket via the dashboard should use POST vs. PUT
1 participant