Add Rate Limiting #121
Merged
Add Rate Limiting #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imRohan
added
the
Ready for Review
Some users have been long polling their Pantry every few ms, which will one day cause problems for us. To deal with issues like this, we should add a rate-limiting solution as to prevent users from spamming the server. This change addresses the need by: - Adding a Redis based rate-limiting solution - Allowing users to get the contents of a basket 30 times before rate limiting kicks in Resolves #120
imRohan
force-pushed
the
rl-rate-limiting
branch
from
a957b49
to
21d21c4
Compare
|
On getpantry.cloud I'm getting consistently 429 with 1 GET per minute. What's the timeframe for the 30 requests? |
|
Hi @realpxl The rate-limiting logic has been slightly modified since this PR was merged. Here's a link to the lines in question (link). Currently, every user can perform up to 20 In theory, after receiving the 429 response, waiting for around 20s should be more than enough time to refresh your request count. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have been long polling their Pantry every few ms, which will one day
cause problems for us.
To deal with issues like this, we should add a rate-limiting solution as to
prevent users from spamming the server.
This change addresses the need by:
kicks in
Resolves #120