Removed request dependency #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imRohan
added
the
Ready for Review
|
Good catch, lets go ahead and remove it! Happy to get this PR merged in, just update your PR/Commit message and ill hit the button. 💪 |
The request dependency is not used anymore and deprecated, so we removed it. Fixes: #100
|
Hmm, do you know why the ci run failed @imRohan ? Seems like an error in the coveralls action. |
Seems like the 405 error is related to this issue (linked below). Coveralls is down. 👎 https://stackoverflow.com/questions/69247002/fix-405-not-allowed-error-with-coveralls |
|
Can you manually run the action again after the issue at coveralls is resolved? |
Yes, ill keep an eye on it and re-run the actions once Coveralls is back online. |
imRohan
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request dependency is deprecated and should not be used (https://www.npmjs.com/package/request). We also didn't use it in the project, so we deleted it.