Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Money pattern #3109

Merged
merged 11 commits into from
Jan 6, 2025
Merged

Money pattern #3109

merged 11 commits into from
Jan 6, 2025

Conversation

Ahmed-Taha-981
Copy link
Contributor

@Ahmed-Taha-981 Ahmed-Taha-981 commented Dec 4, 2024

the implementation of the money pattern and the tests along with the read me file

Close #1305

the implementation of the money patter and the tests along with the read me file
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, add App.java or similar that demonstrates usage of Money class

money/README.md Outdated Show resolved Hide resolved
money/README.md Show resolved Hide resolved
money/README.md Outdated Show resolved Hide resolved
money/README.md Outdated Show resolved Hide resolved
money/README.md Outdated Show resolved Hide resolved
money/pom.xml Outdated Show resolved Hide resolved
@Ahmed-Taha-981
Copy link
Contributor Author

Thank you for your feedback, I added the App.java file and changed all the issues you pointed out.

iluwatar
iluwatar previously approved these changes Jan 6, 2025
@iluwatar iluwatar merged commit cdb78d7 into iluwatar:master Jan 6, 2025
1 check passed
@iluwatar
Copy link
Owner

iluwatar commented Jan 6, 2025

Looks good! Thank you for the contribution 🎉

@all-contributors please add @Ahmed-Taha-981 for code

Copy link
Contributor

@iluwatar

I've put up a pull request to add @Ahmed-Taha-981! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Money pattern
2 participants