Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] : Adding Stack approach to check a string is palindrome or not #224

Closed

Conversation

Ritabrata1080
Copy link

@Ritabrata1080 Ritabrata1080 commented Oct 12, 2024

What the PR solves


Adding another way of checking a string is palindrome or not, by using Dequeue.

Lists of checks executed


  • Copyright year updated
  • Added logs for complex functionalities
  • Added test cases for the newly written APIs

@Ritabrata1080 Ritabrata1080 force-pushed the ritab-java-codes branch 2 times, most recently from f1e1c85 to 19546ab Compare October 12, 2024 18:26
@Ritabrata1080 Ritabrata1080 marked this pull request as ready for review October 12, 2024 18:43
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Ritabrata1080 Ritabrata1080 changed the title [Java] : Adding 2 more ways to test a given string is palindrome or not. [Java] : Adding Stack approach to check a string is palindrome or not Oct 12, 2024
Copy link
Contributor

@Damian-crypto Damian-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it looks good! The changes are straightforward, and everything seems in order.

@Ritabrata1080
Copy link
Author

@iluwatar plz review this PR.

Thanks

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

stale bot commented Dec 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale label Dec 4, 2024
Copy link

stale bot commented Jan 18, 2025

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants