fix: add unit to extra arg help message (helm#391)

The help message for the --helm-extra-args config used an example without units, which caused to fail the next chart-testing run if just copy-pasted. Signed-off-by: Christopher Zell <[email protected]>
ilmax · Mar 15, 2022 · a08bcf2 · a08bcf2
1 parent c2b3d2d
commit a08bcf2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/ct/cmd/install.go b/ct/cmd/install.go
@@ -63,7 +63,7 @@ func addInstallFlags(flags *flag.FlagSet) {
 		the ID of a pull request. If not specified, the name of the chart is used`))
 	flags.String("helm-extra-args", "", heredoc.Doc(`
 		Additional arguments for Helm. Must be passed as a single quoted string
-		(e.g. "--timeout 500"`))
+		(e.g. "--timeout 500s"`))
 	flags.Bool("upgrade", false, heredoc.Doc(`
 		Whether to test an in-place upgrade of each chart from its previous revision if the
 		current version should not introduce a breaking change according to the SemVer spec`))

diff --git a/doc/ct_install.md b/doc/ct_install.md
@@ -49,7 +49,7 @@ ct install [flags]
       --excluded-charts strings        Charts that should be skipped. May be specified multiple times
                                        or separate values with commas
       --helm-extra-args string         Additional arguments for Helm. Must be passed as a single quoted string
-                                       (e.g. "--timeout 500")
+                                       (e.g. "--timeout 500s")
       --helm-extra-set-args string     Additional arguments for Helm. Must be passed as a single quoted string
 		                               (e.g. "--set=name=value")
       --helm-repo-extra-args strings   Additional arguments for the 'helm repo add' command to be

diff --git a/doc/ct_lint-and-install.md b/doc/ct_lint-and-install.md
@@ -41,7 +41,7 @@ ct lint-and-install [flags]
       --excluded-charts strings        Charts that should be skipped. May be specified multiple times
                                        or separate values with commas
       --helm-extra-args string         Additional arguments for Helm. Must be passed as a single quoted string
-                                       (e.g. "--timeout 500")
+                                       (e.g. "--timeout 500s")
       --helm-extra-set-args string     Additional arguments for Helm. Must be passed as a single quoted string
 		                           (e.g. "--set=name=value")                                       
       --helm-repo-extra-args strings   Additional arguments for the 'helm repo add' command to be