Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Crash on joining world #130

Closed
tmvkrpxl0 opened this issue Aug 5, 2024 · 0 comments
Closed

[Bug]: Crash on joining world #130

tmvkrpxl0 opened this issue Aug 5, 2024 · 0 comments
Assignees
Labels
status: confirmed This issue or pull request has been accepted type: bug Something isn't working

Comments

@tmvkrpxl0
Copy link

Minecraft Version

1.20.1

What happened?

When I join the world, it sometimes crashes immediately with ConcurrentModificationException: null. I think it's because of this line:

private static final Map<String, Boolean> CACHE = new HashMap<>();

Forge loads mods in parallel so I think you should use ConcurrentHashMap

How do you trigger this bug?

  1. Join world
  2. ???
  3. Crash
    ...

Loader

Forge

Loader Version

Forge 47.2.30

API Version

N/A

Mod Version

elytraslot-forge-6.4.3+1.20.1

Relevant Log Outputs

https://mclo.gs/5P6axOh

@tmvkrpxl0 tmvkrpxl0 added status: triage This issue or pull request is awaiting review type: bug Something isn't working labels Aug 5, 2024
@TheIllusiveC4 TheIllusiveC4 added status: confirmed This issue or pull request has been accepted and removed status: triage This issue or pull request is awaiting review labels Sep 10, 2024
TheIllusiveC4 added a commit that referenced this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed This issue or pull request has been accepted type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants