-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nix and signal-hook dependencies #50
Conversation
Thanks a lot for this! |
I will work on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Could please update the "Dependencies" sections of the README as well:
- Removing mentions of
nix
andsignal-hook
- Removing the sentence "Safe wrappers are preferred...", which doesn't really apply anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This reduces the dependencies from 9 to 2, the binary size (striped) from 515kb to 435kb (15%) and the build time from 9.36s to 2.96s , while it increases the line count from 1006 to 1012.
The editor in single thread, so I think the signal handling is ok, but it need to be reviewed.