Added struct DtCrowdScopedTimer to avoid allocations in scoped timer calls @wrenge

- #54

Author: ikpil

CHANGELOG.md

@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Added
 - Added RcCircularBuffer<T> [@ikpil](https://github.com/ikpil)
+- Added struct DtCrowdScopedTimer to avoid allocations in scoped timer calls. [@wrenge](https://github.com/wrenge)
 
 ### Fixed
 

src/DotRecast.Detour.Crowd/DtCrowd.cs

@@ -20,6 +20,7 @@ 3. This notice may not be removed or altered from any source distribution.
 
 using System;
 using System.Collections.Generic;
+using System.Threading.Tasks;
 using DotRecast.Core;
 using DotRecast.Core.Collections;
 using DotRecast.Core.Numerics;

src/DotRecast.Detour.Crowd/DtCrowdScopedTimer.cs

@@ -0,0 +1,23 @@
+using System;
+
+namespace DotRecast.Detour.Crowd
+{
+    internal readonly struct DtCrowdScopedTimer : IDisposable
+    {
+        private readonly DtCrowdTimerLabel _label;
+        private readonly DtCrowdTelemetry _telemetry;
+
+        internal DtCrowdScopedTimer(DtCrowdTelemetry telemetry, DtCrowdTimerLabel label)
+        {
+            _telemetry = telemetry;
+            _label = label;
+
+            _telemetry.Start(_label);
+        }
+
+        public void Dispose()
+        {
+            _telemetry.Stop(_label);
+        }
+    }
+}

src/DotRecast.Detour.Crowd/DtCrowdTelemetry.cs

@@ -27,24 +27,6 @@ namespace DotRecast.Detour.Crowd
 {
     public class DtCrowdTelemetry
     {
-        public readonly struct DisposableHandle : IDisposable
-        {
-            private readonly DtCrowdTimerLabel _label;
-            private readonly DtCrowdTelemetry _telemetry;
-
-            public DisposableHandle(DtCrowdTelemetry telemetry, DtCrowdTimerLabel label)
-            {
-                _telemetry = telemetry;
-                _label = label;
-            }
-
-            public void Dispose()
-            {
-                _telemetry.Stop(_label);
-            }
-        }
-            
-        
         public const int TIMING_SAMPLES = 10;
         private float _maxTimeToEnqueueRequest;
         private float _maxTimeToFindPath;
@@ -87,18 +69,17 @@ public void RecordMaxTimeToFindPath(float time)
             _maxTimeToFindPath = Math.Max(_maxTimeToFindPath, time);
         }
 
-        public DisposableHandle ScopedTimer(DtCrowdTimerLabel label)
+        internal DtCrowdScopedTimer ScopedTimer(DtCrowdTimerLabel label)
         {
-            Start(label);
-            return new DisposableHandle(this, label);
+            return new DtCrowdScopedTimer(this, label);
         }
 
-        private void Start(DtCrowdTimerLabel name)
+        internal void Start(DtCrowdTimerLabel name)
         {
             _executionTimings.Add(name, RcFrequency.Ticks);
         }
 
-        private void Stop(DtCrowdTimerLabel name)
+        internal void Stop(DtCrowdTimerLabel name)
         {
             long duration = RcFrequency.Ticks - _executionTimings[name];
             if (!_executionTimingSamples.TryGetValue(name, out var cb))
@@ -110,7 +91,5 @@ private void Stop(DtCrowdTimerLabel name)
             cb.PushBack(duration);
             _executionTimings[name] = (long)cb.Average();
         }
-
-
     }
 }